Feature/11 - Multi server support #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Everything is now implemented except the new ActionHandlerResolver - Need to refactor ActionHandlers to accept new generic ActionHandlerMessage - Implemented new DiscordMessageResolver - Reorganised container, though there is still more work to do; many elements can now be auto-loaded - Added / updated numerous module-alias aliases
- Currently only supports discord, but adding a new listener now means simply creating three new files in the corresponding chatListener directory - IoC still needs automating - this should be much simpler for most registrations with the new directory structure - All Action Handlers have now been updated to use the latest message format
Bidthedog
added
enhancement
|
Closed as I'm moving my development into a DNI repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactor; the bot has now been updated to easily support multi-server monitoring.
More work is required around configuring and enabling / disabling actions on a per-server basis, but this will form part of the Twitch integration work I will be doing next.
This is pretty much ready to go into master if you're happy. Let me know if you need me to explain any of the architectural decisions I've made here.
There's no reason this couldn't go into 1.0.0, though I've tagged this as part of 1.1.0.
This addresses the following issues:
#25 - There is now a new "GenericActionHandler" that is resolved only when no bang-command is found. At present it doesn't do much, but this can be used to monitor incoming none-command messages for any server.
#11 - Pretty much complete, though I've not bothered with a message bus.
#2 - Many more unit tests. Bot.js is now much, much simpler, but there are no tests for it - I've got some minor tweaks to make to how it loads the servers on startup, at which point I'll write tests for it.